Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnowflakeSource does not properly construct table query string #4130

Closed
TomSteenbergen opened this issue Apr 23, 2024 · 0 comments
Closed

SnowflakeSource does not properly construct table query string #4130

TomSteenbergen opened this issue Apr 23, 2024 · 0 comments

Comments

@TomSteenbergen
Copy link
Contributor

TomSteenbergen commented Apr 23, 2024

Expected Behavior

If I pass schema="my_schema" and table="my_table" when creating a SnowflakeSource, I would expect that SnowflakeSource.get_table_query_string outputs '"my_schema"."my_table"'.

Current Behavior

Currently, SnowflakeSource.get_table_query_string outputs "my_table".

Steps to reproduce

  1. Create a SnowflakeSource by specifying the schema and table
  2. Create a FeatureView and FeatureService using above SnowflakeSource
  3. Use get_historical_features and Snowflake will throw an error that it doesn't know the table if the schema in your offline store config is not the same as the schema of your table.

Specifications

  • Version: 0.37.1
  • Platform: MacOS
  • Subsystem: Sonoma 14.4.1

Possible Solution

I filed a PR here: #4131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant