Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix for possible Cross-site-scripting (XSS) attack #4353

Open
shuchu opened this issue Jul 15, 2024 · 3 comments · Fixed by #4355
Open

Security fix for possible Cross-site-scripting (XSS) attack #4353

shuchu opened this issue Jul 15, 2024 · 3 comments · Fixed by #4355

Comments

@shuchu
Copy link
Collaborator

shuchu commented Jul 15, 2024

Reference :
https://sonarcloud.io/project/security_hotspots?id=shuchu_feast&hotspots=AY9leJjfaz5TZ8maDgoc
https://sonarcloud.io/project/security_hotspots?id=shuchu_feast&hotspots=AY9leJk3az5TZ8maDgo8

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

Set the autoescape=True in Jinjia2 Environment()

@jskrzypek
Copy link

@franciscojavierarceo The change that closed this issue (#4355) was reverted later in #4357. Shouldn't this issue be reopened? I can't find discussion about whether or not it worked or why it was reversed.

@tokoko
Copy link
Collaborator

tokoko commented Aug 1, 2024

@jskrzypek yeah, you're right. I'll reopen the issue. The PR broke integration tests, that's why it was reverted. I'm not sure exactly why though, something about escaping special characters. We figured out that this PR was to blame for the failures a little too late, so most of the discussion was in Slack.

@tokoko tokoko reopened this Aug 1, 2024
@jskrzypek
Copy link

jskrzypek commented Aug 2, 2024

Thanks! Yeah, I was reading the changelog for 0.40.0 and saw both the fix: Avoid XSS attack... and then down below the Revert "fix: Avoid XSS attack..." so I got curious 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants