Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Feature Serving and Model Inference Diagram #4455

Closed
franciscojavierarceo opened this issue Aug 27, 2024 · 4 comments
Closed

Provide Feature Serving and Model Inference Diagram #4455

franciscojavierarceo opened this issue Aug 27, 2024 · 4 comments
Assignees
Labels
kind/feature New feature or request

Comments

@franciscojavierarceo
Copy link
Member

Is your feature request related to a problem? Please describe.
We have outlined some options for feature serving and model inference in this documentation: https://docs.feast.dev/v/master/getting-started/architecture/model-inference

In it, we briefly discuss communication patterns and their tradeoffs (elaborated further here: https://docs.feast.dev/v/master/getting-started/architecture/write-patterns).

We don't have an architecture diagram to support these pieces.

Describe the solution you'd like
For a Fintech article I'm writing, I ended up drafting this diagram. I think we could potentially adjust this to use in our documentation.

Screenshot 2024-08-27 at 6 38 42 AM

Describe alternatives you've considered
N/A

Additional context
Good diagrams provide clarity and what not, so I thought this would be useful.

@franciscojavierarceo
Copy link
Member Author

@tokoko any thoughts here? Otherwise I'll cut a PR with this to add to the documentation. I think it's missing the registry, so I could add that as well.

@tokoko
Copy link
Collaborator

tokoko commented Sep 4, 2024

a couple of remarks

  • should feast box contain training datasets? Once they are generated, they are effectively outside of feast at that point.
  • What does a line coming from an online store marked Logs/CDC/ELT refer to?

@franciscojavierarceo
Copy link
Member Author

franciscojavierarceo commented Sep 4, 2024

That's a good call out!

The logs/CDC/ELT refers to logs that should be sent from the feature server during transformations. This is the suggestion I would make to most folks to ensure feature and model reproducibility/replay.

It could be events to SQS or Kafka/Kinesis or through a sidecar. We don't support this in Feast right now but it could be a valuable thing. It's somewhat complicated though.

@franciscojavierarceo
Copy link
Member Author

franciscojavierarceo commented Sep 24, 2024

@tokoko I added the training datasets and a registry, lmk what you think.

feast_model_serving_architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants