Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish TypeScript type declarations in Feast UI package #4539

Closed
peruukki opened this issue Sep 19, 2024 · 0 comments · Fixed by #4551
Closed

Publish TypeScript type declarations in Feast UI package #4539

peruukki opened this issue Sep 19, 2024 · 0 comments · Fixed by #4551
Labels
kind/feature New feature or request

Comments

@peruukki
Copy link
Contributor

Is your feature request related to a problem? Please describe.
TypeScript declarations are not available for Feast UI components exported from @feast-dev/feast-ui. If you are using it as a module in a TypeScript project, you need to write the type definitions manually or treat the code as untyped.

Describe the solution you'd like
Declaration files could be bundled in the package, see TypeScript's Publishing page.

Describe alternatives you've considered
Adding type definitions to DefinitelyTyped (i.e. @types/feast-dev__feast-ui) is also possible, but bundling them seems easier since Feast UI already uses TypeScript. Bundled types are also easier to maintain and a better experience for the package consumer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant