From c425ccd1c4ed3c4a34b0c128ae0956082e649d99 Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Wed, 21 Sep 2022 10:14:01 -0700 Subject: [PATCH 1/3] Build dockerfile correctly Signed-off-by: Felix Wang --- sdk/python/feast/infra/feature_servers/multicloud/Dockerfile | 3 +-- .../feast/infra/feature_servers/multicloud/Dockerfile.dev | 3 +-- .../feast/infra/feature_servers/multicloud/requirements.txt | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) delete mode 100644 sdk/python/feast/infra/feature_servers/multicloud/requirements.txt diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile index 751a398ad4..e96065a639 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile @@ -8,9 +8,8 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -COPY . . +RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql]" -RUN pip install -r requirements.txt RUN apt update RUN apt install -y -V ca-certificates lsb-release wget RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev index 751a398ad4..e96065a639 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev @@ -8,9 +8,8 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -COPY . . +RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql]" -RUN pip install -r requirements.txt RUN apt update RUN apt install -y -V ca-certificates lsb-release wget RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb diff --git a/sdk/python/feast/infra/feature_servers/multicloud/requirements.txt b/sdk/python/feast/infra/feature_servers/multicloud/requirements.txt deleted file mode 100644 index 01d08a4eff..0000000000 --- a/sdk/python/feast/infra/feature_servers/multicloud/requirements.txt +++ /dev/null @@ -1 +0,0 @@ -feast[aws,gcp,snowflake,redis,go,mysql] From 295b97379f5dccc57f184435174217a579a54add Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Wed, 21 Sep 2022 10:58:48 -0700 Subject: [PATCH 2/3] Update Signed-off-by: Felix Wang --- sdk/python/feast/infra/feature_servers/multicloud/Dockerfile | 3 ++- .../feast/infra/feature_servers/multicloud/Dockerfile.dev | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile index e96065a639..45d96c2d9a 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile @@ -8,7 +8,8 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql]" +COPY . . +RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev index e96065a639..45d96c2d9a 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev @@ -8,7 +8,8 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql]" +COPY . . +RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget From 4311081dbfa65a17035df2d2a3eef5cdce0afbfd Mon Sep 17 00:00:00 2001 From: Felix Wang Date: Wed, 21 Sep 2022 16:12:58 -0700 Subject: [PATCH 3/3] Fix Signed-off-by: Felix Wang --- sdk/python/feast/infra/feature_servers/multicloud/Dockerfile | 2 +- .../feast/infra/feature_servers/multicloud/Dockerfile.dev | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile index 45d96c2d9a..7dbe5fd0c4 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile @@ -9,7 +9,7 @@ RUN apt update && \ RUN pip install pip --upgrade COPY . . -RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]" +RUN pip install ".[aws,gcp,snowflake,redis,go,mysql]" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev index 45d96c2d9a..7dbe5fd0c4 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev @@ -9,7 +9,7 @@ RUN apt update && \ RUN pip install pip --upgrade COPY . . -RUN pip install ".feast[aws,gcp,snowflake,redis,go,mysql]" +RUN pip install ".[aws,gcp,snowflake,redis,go,mysql]" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget