Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: EntityAction #423

Open
4 of 9 tasks
Miro-Andrin opened this issue May 11, 2021 · 2 comments
Open
4 of 9 tasks

Feature: EntityAction #423

Miro-Andrin opened this issue May 11, 2021 · 2 comments

Comments

@Miro-Andrin
Copy link
Contributor

Miro-Andrin commented May 11, 2021

Feature Request

Handle the EntityAction request in feather/server/src/packet_handlers.rs

Description

This feature request is very similar to #422 but with a lot more values to track.

  • Start sneaking
  • Stop sneaking
  • Leave bed
  • Start sprinting
  • Stop sprinting
  • Start jump with horse
  • Stop jump with horse
  • Open horse inventory
  • Start flying with elytra

wiki
Notice how there is no StopFlyingEvent, so the server is expected to track this value. How this is kept in synch i have no idea. A reasonable first approximation is that we just don't bother with keeping it in synch, as the physics system is still missing #357.
Another noteworthy thing is that the Leave bed packet is not sent by the client if night is changed to day by players sleeping. So a sleep tracking system has to trigger a BedExit event.
Open horse inventory is only sent when pressing the inventory key (default: E) while on a horse — all other methods of opening a horse's inventory (involving right-clicking or shift-right-clicking it) do not use this packet.

@AL1L
Copy link

AL1L commented May 14, 2021

Notice how there is no StopFlyingEvent, so the server is expected to track this value. How this is kept in synch i have no idea.

It's just canceled if they land on the ground, right? Elytras do have higher desync issues that most other things.

@aramperes
Copy link
Contributor

Hey @AL1L, just so you're aware, this is a clean-room project and we should abstain from reading decompiled code from the vanilla server. See https://github.com/feather-rs/feather/blob/main/CONTRIBUTING.md#original-code-code-from-minecraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants