Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

[security] Generated tokens are broadcast to all socket clients (by default) #126

Closed
t2t2 opened this issue Mar 25, 2016 · 2 comments
Closed
Labels
Milestone

Comments

@t2t2
Copy link

t2t2 commented Mar 25, 2016

feathers-auth-broadcast

@daffl
Copy link
Member

daffl commented Mar 25, 2016

Oh dear. This can be fixed quickly though via:

app.service('auth/local').filter(() => false);

Which should probably be the default for all auth services (we don't need their events anwyay).
We were discussing turning off event dispatching by default so you have to enable it explicitly. It would be the more secure but also more confusing approach.

@ekryski
Copy link
Member

ekryski commented Mar 25, 2016

👍 @t2t2 thanks for pointing it out. I was aware of this and have a note in the code but forgot to create an issue and completely forgot about it!

We'll get a fix in for this soon. In the mean time anyone can lock down their services by doing what @daffl mentioned.

@ekryski ekryski added the Bug label Mar 26, 2016
@ekryski ekryski modified the milestones: 1.0, 0.7 Mar 26, 2016
@ekryski ekryski changed the title Generated tokens are broadcast to all socket clients (by default) [security] Generated tokens are broadcast to all socket clients (by default) Mar 26, 2016
@ekryski ekryski mentioned this issue Mar 30, 2016
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants