Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Python does not read all keys from registry if feature is defined with multiple keys #679

Closed
1 of 4 tasks
blrchen opened this issue Sep 19, 2022 · 0 comments · Fixed by #676
Closed
1 of 4 tasks
Labels
bug Something isn't working

Comments

@blrchen
Copy link
Collaborator

blrchen commented Sep 19, 2022

Willingness to contribute

No. I cannot contribute a bug fix at this time.

Feathr version

v0.7.2

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 20.0):
  • Python version:
  • Spark version, if reporting runtime issue:

Describe the problem

Reported by Piyush:
Hi, I was checking out this PR: https://github.com/feathr-ai/feathr/pull/601/files, seems like this now limits to reading only single key per feature while reading it back from registry, however, While defining the features there is a provision of associating multiple keys with a Feature. while testing out the fix, this is again causing a key mismatch, but in a different form.

Expected:

  1. Python client should read all keys from registry in _get_features_by_guid_or_entities
  2. Add a test case

Tracking information

No response

Code to reproduce bug

No response

What component(s) does this bug affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React
@blrchen blrchen added the bug Something isn't working label Sep 19, 2022
@Yuqing-cat Yuqing-cat linked a pull request Sep 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant