Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isAutoSelected #500

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Add isAutoSelected #500

merged 5 commits into from
Jan 19, 2024

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Sep 1, 2023 •
edited by pr-preview bot
Loading

Fixes #497

Preview | Diff

@npm1 npm1 requested a review from yi-gu September 1, 2023 20:55
yi-gu
yi-gu approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@yi-gu yi-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yi-gu yi-gu mentioned this pull request Sep 5, 2023
Closed
1 task
@npm1
Copy link
Collaborator Author

npm1 commented Sep 5, 2023

Hey @bvandersloot-mozilla @martinthomson @cboozar requesting Mozilla to take a look.

cbiesinger
cbiesinger reviewed Sep 5, 2023
View reviewed changes
spec/index.bs Outdated Show resolved Hide resolved
@yi-gu yi-gu mentioned this pull request Sep 5, 2023
Closed
@npm1 npm1 changed the title Add isAccountAutoSelected Add isIdentityCredentialAutoSelected Oct 12, 2023
samuelgoto
samuelgoto reviewed Oct 18, 2023
View reviewed changes
spec/index.bs Outdated Show resolved Hide resolved
spec/index.bs Outdated Show resolved Hide resolved
samuelgoto
samuelgoto approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm1 npm1 changed the title Add isIdentityCredentialAutoSelected Add isAutoSelected Oct 18, 2023
bvandersloot-mozilla
bvandersloot-mozilla reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@bvandersloot-mozilla bvandersloot-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@samuelgoto
Copy link
Collaborator

Thanks @bvandersloot-mozilla ! Merging!

@samuelgoto samuelgoto merged commit 6bc6819 into main Jan 19, 2024
2 checks passed
@samuelgoto samuelgoto deleted the isAccountAuto branch January 19, 2024 17:12
github-actions bot added a commit that referenced this pull request Jan 19, 2024
@npm1 @github-actions
Add isAutoSelected (#500)
6e7f218 
SHA: 6bc6819
Reason: push, by samuelgoto

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to mattdanielbrown/WebID that referenced this pull request Jan 20, 2024
@npm1 @github-actions
Add isAutoSelected (w3c-fedid#500)
4195d08 
SHA: 6bc6819
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbiesinger cbiesinger cbiesinger left review comments

@bvandersloot-mozilla bvandersloot-mozilla bvandersloot-mozilla left review comments

@samuelgoto samuelgoto samuelgoto approved these changes

@yi-gu yi-gu yi-gu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: provide developers more visibility of auto re-authentication
5 participants
@npm1 @samuelgoto @cbiesinger @yi-gu @bvandersloot-mozilla