-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki page missing, yet its content shows up in wiki search... #284
Comments
Update. I found the page from the wiki search, by clicking the color wiki icon square in the browser (not the blue link in the browser). The page loaded, in the open window, I forked the page, but the only the page paragraph in the observable in the wiki browser forked. Is this my user error. I noticed another inconsistency (not 100 percent sure) I found I could fork the page without signing to my wiki account. Again the fork was only the paragraph seen in the wiki search browser preview. Any chance the wiki server DB has reached its allocated size limit, and is now writing beyond memory? A similar pattern infamously happened to FourSquare whose database had disk space but the space was not allocated in DB, which caused the index to be searchable but the document pages were not found (I think 4sq was on mongodb) |
Interesting... Looking at the list of pages, I see the slug is You ask, "User error?" - well that may be, but it uncovers some inconsistency in how spaces in links, titles, and slugs are trimmed. Which will need investigating. In the sitemap we see,
which suggests that the trailing space in the title has been trimmed off at some point. Which creates a mismatch between the slug generated from the title, and the slug used to save the page - which almost certainly explains the other strangeness. |
@WardCunningham - finally back to looking at this again. On the face of it, it looks as if it should be just a matter of trimming off any spaces. But, I see there is a test, which suggest that this is intended behaviour.
I think this test is wrong, and it should be expecting That said, without a change on the server to detect, and correct, any pages that had spaces at the beginning/end of the title will become inaccessible. |
I feel like in any situation where the spaces would be visible we would be justified in honoring them. A case could be made that trailing spaces are invisible when typing into the Create New Page form from the hamburger menu and would be improved by trimming input. |
Noted elsewhere: |
I feel trailing spaces in the page title are inadvertent typing. |
Yes. I recognize that it is not what was intended. This falls into the same category as a typo that could be corrected by a spell checker. The question becomes that of when the correction is to be applied. As typed? As stored? As displayed? I can think of two simple solutions that were available to me in the beginning:
Both of these would be an "as typed" solutions that are no longer available to us. Now might be a good time for Paul to elaborate what he might have been thinking when he says, "change on the server to detect, and correct". Aside: We are generous as to what we allow as a title. The conversion to slug is lossy and introduces ambiguity, some of which is desirable. A slug is converted to title by retrieving the definitive text from the page json. I say we are generous as one can find obscure unicode in titles, including double spaces and emoji, but not ]] because we offer no way to type that inside [[ and ]]. |
Maybe the start/end spaces should be shown as |
Any idea why a wiki page goes missing?
http://clive.tries.fed.wiki/view/recent-changes/view/teradata-v-sap
The page content shows up in search.
I am using a Chromebox, as I normally do writing on wiki, with the latest ChromeOS.
![page missing found in search](https://user-images.githubusercontent.com/733870/152479884-611322e0-d949-4f0e-8f1c-9c3a561d9bdf.png)
I write this page from about 1 am to 3 am PST Feb 3, 2022.
Thanks for any pointers.
The text was updated successfully, but these errors were encountered: