Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not displaying default remote if it is not named "origin" #63

Closed
janpipek opened this issue Jan 4, 2018 · 1 comment · Fixed by #119
Closed

Not displaying default remote if it is not named "origin" #63

janpipek opened this issue Jan 4, 2018 · 1 comment · Fixed by #119
Labels
good first issue A very good issue to start contributing help wanted

Comments

@janpipek
Copy link

janpipek commented Jan 4, 2018

I found this randomly when looking for possible causes of #62 .

In your code to display a little info about repos, you explicitly call "git remote show origin". This will fail if the default remote is not called "origin". In such case, it just shows "origin" string.

How to reproduce: Update your .git/config to something like

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "origin_"]
	url = git@github.com:felipecaputo/git-project-manager.git
	fetch = +refs/heads/*:refs/remotes/origin/_*
[branch "master"]
	remote = origin_
	merge = refs/heads/master

Perhaps, it's a marginal issue but anyway...

Cheers,
Jan

@felipecaputo
Copy link
Owner

@janpipek thanks for reporting

I'm currently working in 62. I'll fix this as soon as I finish that, what I hope that will happen in next weekend o/

@felipecaputo felipecaputo added help wanted good first issue A very good issue to start contributing labels Mar 29, 2018
@felipecaputo felipecaputo added this to the 1.5.2 milestone Apr 5, 2018
@felipecaputo felipecaputo removed this from the 1.5.2 milestone Oct 2, 2018
@felipecaputo felipecaputo linked a pull request Oct 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A very good issue to start contributing help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants