Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow phpdocumentor/reflection-docblock v5 #37

Merged
merged 1 commit into from
Feb 11, 2020
Merged

feat: allow phpdocumentor/reflection-docblock v5 #37

merged 1 commit into from
Feb 11, 2020

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Feb 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #37 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage     89.91%   89.91%           
  Complexity       58       58           
=========================================
  Files             8        8           
  Lines           119      119           
=========================================
  Hits            107      107           
  Misses           12       12           

Copy link

@orklah orklah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was about to create the PR. I had a conflict while trying to install Psalm on phpDocumentor packages that are used by this library

@felixfbecker
Copy link
Owner

What is the breaking change in v5? Does it not affect this library?

@orklah
Copy link

orklah commented Feb 11, 2020

Well, it bumped to PHP 7.1 and activated strict_types.

The bump in itself is not an issue because users on PHP7.1 won't have version 5 selected by composer

strict_types are straight forward, CI would have shown if there was a major issue...

I don't know much more...

@felixfbecker felixfbecker changed the title Allow phpdocumentor/reflection-docblock v5 feat: allow phpdocumentor/reflection-docblock v5 Feb 11, 2020
@felixfbecker felixfbecker merged commit a407a6c into felixfbecker:master Feb 11, 2020
@felixfbecker
Copy link
Owner

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants