fix: update minimal reflection-docblock version #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage 89.91% 89.91%
Complexity 58 58
=========================================
Files 8 8
Lines 119 119
=========================================
Hits 107 107
Misses 12 12 |
|
Hi @felixfbecker Do you have some time to look at this PR and release a new version with it ? |
|
Friendly ping @felixfbecker ; this PR could help lot of |
felixfbecker
changed the title
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @felixfbecker
The
4.0.0release has a bug.phpDocumentor/ReflectionDocBlock#111
This was fixed in
4.0.1. But I don't see any reason to not require the last version.Currently, when using
composer update --prefer-lowest, the4.0.0version is installed.This PR will avoid a lot of library to explicitly set the version of the reflection-dockblock, like psalm already did
vimeo/psalm#3967