Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helmfile repo has moved #4

Closed
engson opened this issue Apr 17, 2022 · 16 comments · Fixed by #5
Closed

Helmfile repo has moved #4

engson opened this issue Apr 17, 2022 · 16 comments · Fixed by #5

Comments

@engson
Copy link

engson commented Apr 17, 2022

Helmfile repo has moved. (see roboll/helmfile#1824)
New releases will not work with this plugin.

@dmpe
Copy link

dmpe commented Jun 17, 2022

could this be please updated @feniix ?

@feniix
Copy link
Owner

feniix commented Jun 18, 2022

No because there are no releases in the new helmfile repo, see https://github.com/helmfile/helmfile/releases

@usternik
Copy link

Hey
We are seeing that the new repo was updated two days ago although there are no releases there.
This caused asdf installed helmfile to be unusable.
Can you please take a look?

@tigerquoll
Copy link

Affirm - this plugin is now broken as there is no releases in the new repo.

@usternik
Copy link

@feniix
Buenas
Puedes ayudarnos?

@feniix
Copy link
Owner

feniix commented Jun 20, 2022

No, I cannot fix this until the new repo starts distributing binary versions again.

AFAIK asdf is not meant to "download and build" releases, only get binary files and put them in the correct locations

@feniix
Copy link
Owner

feniix commented Jun 20, 2022

Affirm - this plugin is now broken as there is no releases in the new repo.

Also, this plugin is not broken, it just does not use the new repo because it does not have releases

see:

$ asdf install helmfile 0.138.0
0.136.0  0.138.0  0.138.2  0.138.4  0.138.7  0.139.1  0.139.3  0.139.5  0.139.7  0.139.9  0.140.1  0.142.0  0.143.1  0.143.3  0.143.5
0.137.0  0.138.1  0.138.3  0.138.6  0.139.0  0.139.2  0.139.4  0.139.6  0.139.8  0.140.0  0.141.0  0.143.0  0.143.2  0.143.4  0.144.0

@sparsh2
Copy link

sparsh2 commented Jun 21, 2022

Thanks @feniix for reverting the repo url: c339cf4#diff-f9746898bdf5ee311b5c55bc0b6d8c64901f52940c591089b3bfbda5f5b26c8aR26

@eperdeme
Copy link

Also thanks from us. I think you'd be surprised how many people use this plugin @feniix :) We had 1000's of pipelines fail for us with this change.

@lemeurherve
Copy link

@feniix the first release in the new helmfile organization has been published yesterday: https://github.com/helmfile/helmfile/releases/tag/v0.145.0

Note: while roboll's releases contained only the helmfile binary, helmfile's one(s) are tar.gz archives containing also a LICENSE and README.md files.

@raxod502-plaid
Copy link
Contributor

Can the plugin have support for both old and new repos, so all versions can be installable? This is an issue for our CI so I would be happy to contribute a fix if it will be accepted.

@lemeurherve
Copy link

The best would be to ask helmfile maintainers if they can publish old releases in the new repository. (idk if it's easily possible)

@raxod502-plaid
Copy link
Contributor

I can ask them to do that but in the meantime would a pull request adapting asdf-helmfile to pull from both places be acceptable?

@raxod502-plaid
Copy link
Contributor

Filed #5 to fix this issue

@raxod502-plaid
Copy link
Contributor

Submitted helmfile/helmfile#205 requesting transfer of releases to new repo upstream

@feniix feniix closed this as completed in #5 Jul 1, 2022
@feniix
Copy link
Owner

feniix commented Jul 1, 2022

Beautiful! greatly appreciate the PR!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants