Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository moved permanently #11

Closed
richard-kramer opened this issue Jul 3, 2023 · 4 comments · Fixed by #12
Closed

Repository moved permanently #11

richard-kramer opened this issue Jul 3, 2023 · 4 comments · Fixed by #12

Comments

@richard-kramer
Copy link

richard-kramer commented Jul 3, 2023

It looks like the SOPS repository moved from https://github.com/mozilla/sops to https://github.com/getsops/sops. As a result, the list-all curl call returns this JSON:

{
  "message": "Moved Permanently",
  "url": "https://api.github.com/repositories/40684033/releases",
  "documentation_url": "https://docs.github.com/v3/#http-redirects"
}

This does obviously not work for listing the actual versions. I suspect, installation versions does also break.

As a solution, the URL should be changed to the new one and the curl-call should follow redirects to not break when something like this happens again.

@log2
Copy link

log2 commented Aug 8, 2023

Could you please fix this bug, using PR from @khassel? Thank you

While installing specific versions still works, our dependency management tool breaks badly for sops tool (see here and following lines).

Maybe a common library for managing GitHub-hosted tools, useable across all asdf plugins, could be a good idea in order to factor out facilities like these (following redirects, etc.). cc @fragolinux

@chrodriguez
Copy link

It's really important to approve provided PR, it fixes this issue... Thanks in advance

@fragolinux
Copy link

“That is not dead which can eternal lie, And with strange aeons even PRs may die”

@mdgreenwald
Copy link

Would be great to get #12 merged.

@feniix feniix closed this as completed in #12 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants