Fix misleading DevUI score for void return types

Fixes: quarkusio#27338
fercomunello · Aug 31, 2022 · 09780c5 · 09780c5
1 parent ca2aa9f
commit 09780c5
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/.../main/java/org/jboss/resteasy/reactive/server/core/startup/RuntimeResourceDeployment.java b/.../main/java/org/jboss/resteasy/reactive/server/core/startup/RuntimeResourceDeployment.java
@@ -400,8 +400,7 @@ public RuntimeResource buildResourceMethod(ResourceClass clazz,
                     if (mediaType.isWildcardType() || mediaType.isWildcardSubtype()) {
                         handlers.add(new VariableProducesHandler(serverMediaType, serialisers));
                         score.add(ScoreSystem.Category.Writer, ScoreSystem.Diagnostic.WriterRunTime);
-                    } else if (rawEffectiveReturnType != Void.class
-                            && rawEffectiveReturnType != void.class) {
+                    } else if (isNotVoid(rawEffectiveReturnType)) {
                         List<MessageBodyWriter<?>> buildTimeWriters = serialisers.findBuildTimeWriters(rawEffectiveReturnType,
                                 RuntimeType.SERVER, MediaTypeHelper.toListOfMediaType(method.getProduces()));
                         if (buildTimeWriters == null) {
@@ -444,7 +443,8 @@ public RuntimeResource buildResourceMethod(ResourceClass clazz,
                     score.add(ScoreSystem.Category.Writer, ScoreSystem.Diagnostic.WriterRunTime);
                 }
             } else {
-                score.add(ScoreSystem.Category.Writer, ScoreSystem.Diagnostic.WriterRunTime);
+                score.add(ScoreSystem.Category.Writer, isNotVoid(rawEffectiveReturnType) ? ScoreSystem.Diagnostic.WriterRunTime
+                        : ScoreSystem.Diagnostic.WriterNotRequired);
             }
         } else {
             score.add(ScoreSystem.Category.Writer, ScoreSystem.Diagnostic.WriterRunTime);
@@ -487,6 +487,11 @@ public RuntimeResource buildResourceMethod(ResourceClass clazz,
                 clazz.resourceExceptionMapper());
     }
 
+    private static boolean isNotVoid(Class<?> rawEffectiveReturnType) {
+        return rawEffectiveReturnType != Void.class
+                && rawEffectiveReturnType != void.class;
+    }
+
     private void addResponseHandler(ServerResourceMethod method, List<ServerRestHandler> handlers) {
         if (method.getHandlerChainCustomizers().isEmpty()) {
             handlers.add(ResponseHandler.NO_CUSTOMIZER_INSTANCE);