Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable programmatic invocation of commands without terminal interaction #125

Open
1 task done
kate-goldenring opened this issue Oct 5, 2023 · 3 comments
Open
1 task done

Comments

@kate-goldenring
Copy link
Collaborator

kate-goldenring commented Oct 5, 2023

The following scenarios require terminal interaction where a flag such as --accept-defaults should be provided for CI scenarios:

  • spin cloud deploy for an app with entries in sqlite_databases (you are prompted to choose a DB)
  • spin cloud link sqlite when updating a link
  • spin cloud sqlite delete you are prompted to confirm your choice to delete the database
@kate-goldenring
Copy link
Collaborator Author

@itowlson am i missing anything here?

@itowlson
Copy link
Contributor

itowlson commented Oct 5, 2023

I think that's the lot.

Looking over it, we don't have a very clear policy on confirming destructive actions at the moment (e.g. app delete and sqlite unlink don't confirm, but sqlite delete does), and it's not clear where a good boundary would be (e.g. sqlite execute could be phenomenally destructive but would be a massive pain to have a confirmation on). But if we get a good pattern in for the commands you've listed then that will put us in good stead if we ever add confirmation to any of those. (This is definitely out of scope for this issue of course! I'm just thinking out loud.)

@kate-goldenring
Copy link
Collaborator Author

kate-goldenring commented Oct 5, 2023

Looks like we already have the yes flag for deletes. We could add the same to unlink; though, unlink is easy enough to undo that it might not need a prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants