Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pooling allocator automatically in environments where it will fail #2343

Closed
lann opened this issue Mar 11, 2024 · 2 comments · Fixed by #2508
Closed

Disable pooling allocator automatically in environments where it will fail #2343

lann opened this issue Mar 11, 2024 · 2 comments · Fixed by #2508
Labels
bug Something isn't working

Comments

@lann
Copy link
Collaborator

lann commented Mar 11, 2024

There are (at least) two environments where the Wasmtime pooling allocator is known to fail with Spin's default settings:

QEMU: #1785
Systems with <2GB (?) RAM: #2119

Under spin up we should try to detect either of these environments and disable pooling (with a message) to improve UX.

@lann
Copy link
Collaborator Author

lann commented Mar 11, 2024

Ideally this could be done by trying some operation known to fail with pooling (and retrying with pooling disabled to confirm) at boot time rather than detecting these specific issues, as long as this check is reasonably quick.

That might just be any module instantiation under the proper engine config.

@vdice vdice moved this to 🆕 Triage Needed in Spin Triage Mar 13, 2024
@vdice vdice added the bug Something isn't working label Mar 13, 2024
@vdice vdice moved this from 🆕 Triage Needed to 🔖 Backlog in Spin Triage Mar 13, 2024
@lann
Copy link
Collaborator Author

lann commented May 14, 2024

bytecodealliance/wasmtime#8610 would likely work for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants