Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules with duplicate imports cannot be componentized #2778

Closed
lann opened this issue Aug 28, 2024 · 3 comments
Closed

Modules with duplicate imports cannot be componentized #2778

lann opened this issue Aug 28, 2024 · 3 comments
Milestone

Comments

@lann
Copy link
Collaborator

lann commented Aug 28, 2024

This is only known to be a problem for Grain where a Hello World wasi preview1 module produces duplicate fd_write imports.

Duplicate imports are permitted in modules by the Wasm core spec but forbidden by the component model, which prevents these modules from being componentized.

Two plausible paths to fix this:

While fixing Grain is probably independently a good idea, we don't necessarily control that timing and it wouldn't help for existing modules. A discussion of how to build dedupe tooling can be found in BA Zulip.

@lann
Copy link
Collaborator Author

lann commented Aug 28, 2024

It turns out this is only an issue for Grain with debug builds. Compiling with --release solves the problem.

@vdice
Copy link
Member

vdice commented Nov 4, 2024

@lann now that the grain template and language page have been updated to use --release, do we still want to keep this open? Untether from Spin 3.0 if so?

@lann
Copy link
Collaborator Author

lann commented Nov 4, 2024

No my understanding is that this is working as intended on the wasmtime side.

@lann lann closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants