factor-outbound-networking: Add support for client TLS #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
force-pushed
the
factors-client-tls
branch
2 times, most recently
from
f6692dc to
64ca67e
Compare
lann
force-pushed
the
factors-client-tls
branch
from
64ca67e to
8585f6d
Compare
|
@rajatjindal FYI |
|
@rylev I'll be particularly interested in your thoughts on the RuntimeConfig approach. |
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
factors-client-tls
branch
from
8585f6d to
c7a7319
Compare
lann
commented
Aug 2, 2024
There was a problem hiding this comment.
These are copied from spin-trigger-http tests.
Merged
rylev
approved these changes
Aug 12, 2024
| // Validate hostname | ||
| http::uri::Authority::from_str(host).with_context(|| format!("invalid TLS 'host' {host:?}"))?; | ||
| if host.contains(':') { | ||
| anyhow::bail!("invalid TLS 'host' {host:?}; ports not currently supported"); |
There was a problem hiding this comment.
It's not clear to me why ports aren't supported. What would happen if this check were removed?
There was a problem hiding this comment.
The behavior didn't seem obvious enough to me to roll it into a refactor.
| fn deserialize_hosts<'de, D: Deserializer<'de>>(deserializer: D) -> Result<Vec<String>, D::Error> { | ||
| let hosts = Vec::<String>::deserialize(deserializer)?; | ||
| for host in &hosts { | ||
| validate_host(host).map_err(serde::de::Error::custom)?; |
There was a problem hiding this comment.
If we're going to validate the host later, is there really a need for it here?
There was a problem hiding this comment.
Validating here gives nice TOML errors.
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the
[[client_tls]]runtime config logic fromspin-triggertospin-factor-outbound-networking.This rewords the keys used in that runtime config section, which is a breaking change but I think its less confusing and worth it given that ~no one is using it yet and it will be released with 3.0.
This also switch from using
Authorityto a plain string for hostnames. UsingAuthoritywas my idea but I realize now that it makes things awkward when trying to deal with port numbers, so I bailed out to just plainhost: String, though still usingAuthority's parser to validate that string.The
rustls::ClientConfigderived from this runtime config is exposed to dependent factors viaInstanceBuilder::component_tls_configs.