Support interceptor in spin outbound http #2817
Conversation
| use spin_world::async_trait; | ||
| use wasmtime_wasi_http::{body::HyperOutgoingBody, HttpResult}; | ||
|
|
||
| pub type HyperBody = HyperOutgoingBody; |
There was a problem hiding this comment.
This seems a bit unnecessary? I don't see how HyperBody is clearer than HyperOutgoingBody
There was a problem hiding this comment.
It's used in the Complete variant below, where it is actually an incoming body. I don't really know why wasmtime_wasi_http has both types; they alias the same underlying type...
| pub trait OutboundHttpInterceptor: Send + Sync { | ||
| /// Intercept an outgoing HTTP request. | ||
| /// | ||
| /// If this method returns [`InterceptedResponse::Continue`], the (possibly |
There was a problem hiding this comment.
I think the docs here are slightly wrong since we're no longer updating requests but rather passing the request and back out.
There was a problem hiding this comment.
You can still update it, just as owned-mut rather than &mut. 🤷
| } | ||
|
|
||
| impl InterceptRequest { | ||
| pub fn into_hyper_request(self) -> Request<HyperBody> { |
There was a problem hiding this comment.
Can this also be pub(crate)?
There was a problem hiding this comment.
External impls need it to get the request body in the InterceptOutcome::Complete path.
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
lann
force-pushed
the
intercept-spin
branch
from
987cb41 to
24ab63b
Compare
InterceptRequestwrapper type to handle differences between spin and wasi requestsinterceptrequest param owned to be returned inInterceptOutcome::Continuebranch, replacing awkwardstd::mem::take