Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when creating and destroying peer with wrtc on node #887

Open
soenkehahn opened this issue Apr 28, 2022 · 1 comment
Open

Segfault when creating and destroying peer with wrtc on node #887

soenkehahn opened this issue Apr 28, 2022 · 1 comment

Comments

@soenkehahn
Copy link

What version of this package are you using?

9.11.1

What operating system, Node.js, and npm version?

ubuntu 22.04
node 18.0.0
npm 8.6.0
yarn 1.22.17

What happened?

When creating a Peer with wrtc under node and calling .destroy() on that peer, node segfaults. A small reproducing example can be found here: https://github.com/soenkehahn/simple-peer-bug

What did you expect to happen?

The peer should be destroyed successfully.

Are you willing to submit a pull request to fix this bug?

I have no idea what causes this. So I'd appreciate some debugging help. If it's an easy fix, I'd be willing to provide a PR.

@jzombie
Copy link

jzombie commented May 19, 2022

I believe this has been an ongoing problem with the wrtc package on node for a while (two years or more). I experienced a very similar issue in 2020 using the wrtc package and it wasn't using simple-peer, so I don't think the issue is w/ simple-peer itself.

I worked around it for my own needs by running a headless Chromium instance on the server and proxying the WebRTC calls to the Node.js runtime; it was a lot more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants