-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'dependencies' field in AEA configuration #2289
Add 'dependencies' field in AEA configuration #2289
Conversation
for backward compatibility
c559ed5
to
477dc52
Compare
63fcada
to
98f0aa0
Compare
}, | ||
"dependencies": { | ||
"$ref": "definitions.json#/definitions/dependencies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is currently optional for backward compatibility, but will be made mandatory in the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason: otherwise many tests that rely on the remote registry would fail (e.g. aea upgrade
tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please open issue so we don't forget to make it strict later.
Co-authored-by: David Minarsch <david.minarsch@googlemail.com>
Codecov Report
@@ Coverage Diff @@
## fix/crypto-plugin #2289 +/- ##
====================================================
Coverage ? 99.45%
====================================================
Files ? 420
Lines ? 30655
Branches ? 0
====================================================
Hits ? 30488
Misses ? 167
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Proposed changes
Add
dependencies
field in AEA configuration.Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.aea cli
tool worksFurther comments
n/a