Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'dependencies' field in AEA configuration #2289

Merged
merged 8 commits into from
Feb 23, 2021

Conversation

marcofavorito
Copy link
Contributor

Proposed changes

Add dependencies field in AEA configuration.

Fixes

n/a

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Comment on lines +154 to +156
},
"dependencies": {
"$ref": "definitions.json#/definitions/dependencies"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is currently optional for backward compatibility, but will be made mandatory in the next release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason: otherwise many tests that rely on the remote registry would fail (e.g. aea upgrade tests).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please open issue so we don't forget to make it strict later.

docs/config.md Outdated Show resolved Hide resolved
marcofavorito and others added 2 commits February 23, 2021 15:08
Co-authored-by: David Minarsch <david.minarsch@googlemail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (fix/crypto-plugin@8c92aa8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             fix/crypto-plugin    #2289   +/-   ##
====================================================
  Coverage                     ?   99.45%           
====================================================
  Files                        ?      420           
  Lines                        ?    30655           
  Branches                     ?        0           
====================================================
  Hits                         ?    30488           
  Misses                       ?      167           
  Partials                     ?        0           
Flag Coverage Δ
unittests 99.45% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c92aa8...fca3818. Read the comment docs.

@marcofavorito marcofavorito merged commit d3e5b66 into fix/crypto-plugin Feb 23, 2021
marcofavorito added a commit that referenced this pull request Feb 24, 2021
- add instructions regarding the 'dependencies' field in 'aea-config.yaml';
- add instructions regarding crypto plug-ins.
DavidMinarsch added a commit that referenced this pull request Feb 24, 2021
@DavidMinarsch DavidMinarsch deleted the fix/add-dependencies-aea-config branch February 25, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants