-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing link to package at https://www.rformassspectrometry.org/contributions/ #18
Comments
I guess , a pull request would solve it |
The task is completed once your name shows up on the homepage! ;-) |
Note: we put only developers and packages on the RforMassSpectrometry homepage that are on the RforMassSpectrometry github repo. We maintain and are responsible for all these packages for which we also have full control. Contributors listed on the "Contributors" page have provided code to these packages. That being said, I think it would be maybe good to have a separate section/page with outside contributors and packages that are not part of RforMassSpectrometry, but that implement/extend/support that. IMHO that would be even better than adding your package to the RforMassSpec repo. Any thoughts on that? |
I also think that adding the package to the RforMassSpec repo would be the easier solution. @cpanse? |
@jorainer great; fine with us. let me handle the current pull request and than we can transfer it. What do I need to do? |
Wait a second. Adding a package to R4MS isn't only a matter of transferring to the Github organisation. |
IMHO there is no need to transfer the package to RforMassSpectrometry - I think it's perfectly fine to have it in your repo. There is no need that all packages that extend e.g. Ideal solution for me:
Transferring the package to RforMassSpectrometry would also mean that we would need to take over (at least part) of the maintainance duties - and that's something I simply can not do. There are also other packages around providing |
Has the wind just turned 180 degrees? 😄 |
IMHO: It would be good to get listed here, but I fear the overall effect on package findability will be limited. A direct link on the homepage to all currently available backends could really help to guide potential users that are looking for a specific support. Maybe ordered by data formats? |
no? we never proposed to move the package to R4MS - and as explained, I don't think that's necessary (and actually good). It's more efficient to have independently maintained packages.
yes, that's exactly what I meant with in the Spectra vignette above. Please make a PR to that vignette adding a link to your package. And yes, we have to find a better way to list backends (from R4MS and external ones). Whether the R4MS homepage is the correct place I don't know (also because we're not regularly updating that). Maybe the best place would be the |
ahhh, ok! Sorry. I guess my eyes skipped the |
ok. So our action item is |
I guess this should be the file to edit: https://github.com/RforMassSpectrometry/Spectra/blob/HEAD/vignettes/Spectra.Rmd |
Exactly. In this file there is a section Backends (to the end of the file) that lists already some other backends. Please add a link to yours too, ideally also with a short description what it provides and which data it can handle. |
@jorainer @lgatto @tobiasko rformassspectrometry/Spectra@e1dcac4 I hope you like it. Otherwise, please feel free to change it. |
Thanks! Better you change it - I asked for some changes in your PR :) |
https://www.rformassspectrometry.org
does not mention this package at all. There is also no link to your name in the contribution section @cpanse. This should really change!
The text was updated successfully, but these errors were encountered: