Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music replayer - out of tune #4

Open
Vampier opened this issue May 10, 2022 · 3 comments
Open

Music replayer - out of tune #4

Vampier opened this issue May 10, 2022 · 3 comments

Comments

@Vampier
Copy link

Vampier commented May 10, 2022

First of all thank you for the port of this game to the PSX - we've been having fun with it at PSX FPGA core testing :)

The bass tones and higher tones seem to be looping out of sync with each other which created a dissonant sound.

The sound issue seems to occur on 50 and 60hz - the image seems to try to set itself to the Japanese region (gameid indicates Japanese Region) so 60hz - that's where most of the testing happened.

https://youtu.be/DNo1sYgFTo4 << example

@fgsfdsfgs
Copy link
Owner

I've been aware of this issue, but I was thinking it was some sort of "aliasing" caused by some of the samples looping incorrectly, creating audible popping at a high frequency. Here's another example I captured a long time ago. Unfortunately I still got no clue what causes this to happen.

aliasing.mp4

The sample converter tries to loop the samples such that the resulting sample length is divisible by both the ADPCM block size and the length of the original sample. Could it be that this length difference is making this happen?

The release image has the JP license file injected into it, but the gameplay and the music should still update at 50hz.

@Vampier
Copy link
Author

Vampier commented May 10, 2022

I'm not sure either - I guess depends on the length of the samples and how they are 'looped'/'played'

One thing I have experienced myself in the past was that the frequency (tuning)of the samples might not always be the same. So we have frequency played and frequency of the samples. In game it's hardly noticeable.

@fgsfdsfgs
Copy link
Owner

This has been at least partially fixed in b2ac995 (Release 7), however I'm pretty sure some of the samples are still slightly out of tune, just without the "aliasing" effect. Either that or my hearing is complete shit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants