Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for progressDeadlineSeconds in Deployments #142

Open
xavileon opened this issue Mar 5, 2021 · 0 comments
Open

Support for progressDeadlineSeconds in Deployments #142

xavileon opened this issue Mar 5, 2021 · 0 comments

Comments

@xavileon
Copy link
Contributor

xavileon commented Mar 5, 2021

Kubernetes has the notion of https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds to understand when a deployment is making progress (or not) via a condition. Unless specified, that timeout is set to 10m.

Deployment tools in general (kubectl, spinnaker, argo, etc.) use this condition to signal that a deployment failed. However, FIAAS only checks for the desired vs ready pods which is an incomplete view of what k8s is surfacing.

This issue is to discuss wether FIAAS needs to follow this same pattern and consider the progress condition in deployments.

Some possibilities could be:

  • include a timeout in the ApplicationSpec to create the deployment with a given timeout (default to 0, so it's barckwards compatible with current behaviour).
  • ignore the condition as FIAAS does today and rely exclusively on the desired vs ready pods as of today.
  • others?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant