Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to support only 2.10.6+, 2.11.8+ and 2.12.x #1

Merged
merged 2 commits into from
Apr 7, 2017

Conversation

kailuowang
Copy link
Contributor

Thanks for your nice work. I'd like to recommend this plugin to typelevel/cats users once we get rid of the Unapply machinery per this issue

I made some changes here

  1. support 2.11.9+ with the scalacOption
  2. stop supporting versions prior to 2.10.6 and after 2.13, for 2.10.6- there is no plugin available. For 2.14+ it's too far ahead we don't know if the flag is still supported, by that time this plugin is probably obsolete.
  3. Fail when the scala version falls out of the supported range which is 2.10.6 - 2.13.x

@fiadliel
Copy link
Owner

fiadliel commented Apr 7, 2017

Sorry, this was marked as "not watched", so I didn't see this. Changes look good to me.

Separately, I need to make sure it does the right thing if scalaOrganization is set for TLS, but that can be a different change.

@fiadliel fiadliel merged commit 2df7245 into fiadliel:master Apr 7, 2017
@kailuowang
Copy link
Contributor Author

no worries. Do you plan to release this change or after the scalaOrganization change?

@fiadliel
Copy link
Owner

fiadliel commented Apr 7, 2017

The scalaOrganization check is just a small correction, it can be done in a patch update. Released 1.0.0.

@kailuowang
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants