forked from codemirror/codemirror5
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from master #1
Merged
fidelo-developer
merged 1,645 commits into
fidelo-software:master
from
codemirror:master
Jan 21, 2020
Merged
Update from master #1
fidelo-developer
merged 1,645 commits into
fidelo-software:master
from
codemirror:master
Jan 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- highlighted the namespace itself as a variable. This is in line with how Java packages are highlighted. I believe this is a close approximation. - added 2 tests to verify new highlighting.
- changed classification of param-def-type to "type" instead of using "variable-3" - updated tests to match this expectation
- updated "templ-ref" to match namespaced templates e.g. my.namespaced.component.element. The existing regex matches the first word and nothing after the "." - updated "templ-ref" to treat all "." templates as variable-2. Local templates are the only ones capable of starting with a dot and because a template earlier in the file can reference a local template later in the file, there are no guarantees of it being in the variable list. Treating all .templates as local is more consistent and predictable for syntax highlighting.
- added tokenization for soy functions. Assigned to variable & callee - added tests to verify it works within expressions
- added token "property" to `name` in `{param name: '' /}` - adjusted nested-kind-test for this change.
- added token "type" for ? - added test for single type - added test for ? as a template type parameter
- added tokenization for decimals - added tokenization for hexidecimals - added tokenization for true/false - added test cases for those new atom tokens
- tokenize arithmetic and equality operators as "operator" - added tests to validate this
Because JS seems to be frozen entirely while the context menu is open, the next open might happen before the timeout was able to fire. This forces the previous context menu kludge to be cleared before starting a new one.
It sometimes went wrong due to the textarea wrapper being moved when the cursor was placed under the mouse.
Removal of line widgets is broken in 5.50.0 due to invalid classname check
The external link to the ternjs.net demo page returns a 404 error; this PR corrects it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.