Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update symmetry tutorial with simulations #792

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

henneysq
Copy link
Contributor

@henneysq henneysq commented Jun 11, 2024

This pull request adds details to the tutorial on beamformer source estimation with symmetry constraints to show the effects of this on correlated sources.

@robertoostenveld
Copy link
Member

Instructions for running the website locally are documented here https://github.com/fieldtrip/website/blob/master/README.md#evaluating-the-website-locally

I hope you can get that to work. I use rvm to bootstrap the Jekyll stack.

@henneysq
Copy link
Contributor Author

@robertoostenveld do you want me to add some details to the real-data example based on Popov2018?

@henneysq
Copy link
Contributor Author

STATUS:
The symmetry simulations tutorial now renders in its entirety and contains four examples. I can merge all the code into two for loops instead to make it less comprehensive, but I think this sequential structure is easier to follow as a tutorial.

I will add some descriptions to the plots, and feel free to do the same if you want to attach any comments.

@robertoostenveld
Copy link
Member

Hi Mark, pointing to Popov2018 would be useful. If you feel it looks more or less OK, I suggest to merge, then check out how it looks online (which I will do as well) and then make further small changes.

@henneysq
Copy link
Contributor Author

Hi Mark, pointing to Popov2018 would be useful. If you feel it looks more or less OK, I suggest to merge, then check out how it looks online (which I will do as well) and then make further small changes.

Okay. I will break down and describe the ASSR_lcmv.m script from Popov2018, then mark the PR ready to merge.

@henneysq
Copy link
Contributor Author

I took the ASSR_dics.m from Popov2018 apart and described the content for a single subject.

@henneysq henneysq marked this pull request as ready for review June 14, 2024 10:03
@robertoostenveld robertoostenveld merged commit c8ef0ef into fieldtrip:master Jun 14, 2024
@robertoostenveld
Copy link
Member

let me merge, and let's then have a look at it online.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants