Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't take drawers into account #25

Closed
mplamann opened this issue Jan 8, 2011 · 11 comments
Closed

Doesn't take drawers into account #25

mplamann opened this issue Jan 8, 2011 · 11 comments
Assignees
Labels
Milestone

Comments

@mplamann
Copy link

mplamann commented Jan 8, 2011

When I am using an application that uses drawers (such as TextWrangler), the fullscreen keyboard shortcut does not leave space for the drawer on the right side of the window

@fikovnik
Copy link
Owner

fikovnik commented Jan 9, 2011

Hi,

Thanks for reporting. I will have a look into that to what can be done around it with Accessibility API.

/cheers
Filip

@fikovnik
Copy link
Owner

It seems that the AXDrawer is a child of AXWindow and defines AXSize and AXPosition hence should be possible to use and manage apps with drawers as well. Once new API is done I will update it.

@mplamann
Copy link
Author

Great! I'm looking forward to it.

@chriscrowe
Copy link
Contributor

Any updates on this Filip? I work with Textmate projects a lot, which use a drawer for showing which files you're working with.

@fikovnik
Copy link
Owner

fikovnik commented Feb 6, 2011

Hi,

just pushed it into the increase-reduce branch. Please check it out. Sometimes I experience a bit weird behavior, but I cannot reproduce it. Also I did not check on multiple monitors - will do tomorrow at work.

@chriscrowe
Copy link
Contributor

Works great! Thanks so much for this Filip.

@fikovnik
Copy link
Owner

fikovnik commented Feb 7, 2011

Glad you like it. I experienced a bug in multi-screen settings and pushed in patch. However, there seems to be some timing issues with the AX API - if you try to do many actions very quickly after each other it will produce weird results. It is cause by inaccurate readings from AXDrawer. I introduced a delay in the code ~ 1/3 sec, but still sometimes you can get weird stuff.

@chriscrowe
Copy link
Contributor

I've actually got some undesirable behavior with drawers. Often times it will shift the window + drawer correctly but it won't size the window to 1/2 the screen. Rather, it will size to 1/2 + the size of the drawer.

@fikovnik
Copy link
Owner

I think I experienced the same and when pressed the keys again (sometimes couple of times) it slowly get there :|
I need to find a way how to reproduce it so I can fix it.

@fikovnik
Copy link
Owner

I was wrong! There was a bug with the sizing. Please check the latest code. There is still a problem I mentioned above.

@ghost ghost assigned fikovnik May 27, 2011
@fikovnik
Copy link
Owner

Pushed the drawers fix into the increase-reduce branch (a0ea7f7)
There is however one problem which is currently fix with a bit ugly workaround - run the resizing in a loop up to the numberOfTries settings. This settings is can be only changed using command line:

to set:

defaults write org.shiftitapp.shiftit numberOfTries 10

to get:

defaults read org.shiftitapp.shiftit numberOfTries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants