Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop signable checks #806

Closed
arajasek opened this issue Nov 6, 2022 · 4 comments
Closed

Drop signable checks #806

arajasek opened this issue Nov 6, 2022 · 4 comments
Labels
P1
Milestone
Reenginering buil...

Comments

@arajasek
Copy link
Contributor

arajasek commented Nov 6, 2022 •
edited
Loading

Actors currently checks that the callers of the following methods (not yet exhaustive):

  • Market::AddBalance
  • Market::PublishStorageDeals
  • Multisig::Propose

We should likely drop all such checks as we move to a world with smart contracts -- this work should happen as part of the public actors API effort (#772).
@arajasek arajasek changed the title Drop signable checks from the market actor Drop signable checks Nov 6, 2022
@arajasek arajasek mentioned this issue Nov 6, 2022
Merged
@anorth
Copy link
Member

anorth commented Nov 6, 2022

See also #424

@ZenGround0
Copy link
Contributor

ZenGround0 commented Nov 7, 2022 •
edited
Loading

It should be good already but let's make sure we double check there are no such checks on verified clients too.

@jennijuju jennijuju moved this to 📋 Backlog in Network v18 Nov 7, 2022
@jennijuju jennijuju moved this from 📋 Backlog to 🔖 Ready in Network v18 Nov 7, 2022
@arajasek arajasek mentioned this issue Nov 9, 2022
Merged
@arajasek
Copy link
Contributor Author

arajasek commented Nov 9, 2022

It should be good already but let's make sure we double check there are no such checks on verified clients too.

Double checked 💚

@jennijuju
Copy link
Member

need an audit for the remaining checks

@jennijuju jennijuju moved this from 🔖 Ready to 👀 In review in Network v18 Nov 25, 2022
@jennijuju jennijuju added the P1 label Nov 25, 2022
@jennijuju jennijuju moved this from 👀 In review to ✅ Done in Network v18 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
Reenginering built-in actors API
Development

No branches or pull requests
4 participants
@anorth @ZenGround0 @arajasek @jennijuju