Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Multi Sign Wallet #298

Open
kaola526 opened this issue Sep 16, 2021 · 9 comments
Open

Local Multi Sign Wallet #298

kaola526 opened this issue Sep 16, 2021 · 9 comments
Assignees
Labels

Comments

@kaola526
Copy link

kaola526 commented Sep 16, 2021

1. Proposed issue:

Create a local multi sign wallet lotus wallet new
View the local multi sign wallet lotus wallet list
Allow multi sign wallets to proposal transfer lotus send
Approve to multi address transaction lotus wallet approve

2. Why is this issue important?

Use local multi sign Wallet

3. Tasks

1,lotus wallet new msig
--from: account to send the create message from (Use local Default address when not set)
--value: initial funds to give to multisig (Use 0 when not set)
--required: number of required approvals (uses number of signers provided if omitted)
--duration: length of the period over which funds unlock(Use 0 when not set)
[<address1 address2 ...>]
len(parameters) = 0, all local wallets are used to create multi check wallets
len(parameters) = 1, an error is reported, with at least 2 parameters
len(parameters) > 1, all parameters are used as signers to create a multi sign wallet
2,lotus wallet list
--signers Output signer's address
--required Output number of required approvals
--vesting Output include vesting details
--decode-params Decode parameters of transaction proposals
3,lotus send targetAddress amount
--msig: Specify multi sign wallet address(It must be set to initiate multi sign address transfer)
--from: Set the initiator of multi sign address transfer(Use local Default address when not set,But it must belong to the signers)

4,lotus wallet approve approveAddress multisigAddress transferID [proposerAddress destination value [methodId methodParams]]

@coder-lb
Copy link

Great. After implementing it, it's easier to use multisig wallet.

@jennijuju
Copy link
Member

Would this work with other msig use cases, like using msig for owner address?

@kaola526
Copy link
Author

Would this work with other msig use cases, like using msig for owner address?
We are already doing the owner's experiment. We will submit a PR as soon as possible

@dayou5168
Copy link

dayou5168 commented Sep 17, 2021

Hey. are you going to provide a document on how to use the multi-signature wallet and how to switch miner addresses to the multi-signature wallet?

@kaola526
Copy link
Author

Hey. are you going to provide a document on how to use the multi-signature wallet and how to switch miner addresses to the multi-signature wallet?

Currently in preparation。Reference Resources issue302

@jennijuju
Copy link
Member

jennijuju commented Sep 17, 2021

We should allow user to be able to add the msig they are a signer of to local wallet as well.

See other requirements here:
filecoin-project/lotus#1136

@jennijuju jennijuju added the bounty this issue has a bounty label Sep 17, 2021
@jennijuju jennijuju removed the bounty this issue has a bounty label Sep 17, 2021
@kaola526
Copy link
Author

We should allow user to be able to add the msig they are a signer of to local wallet as well.

See other requirements here:
filecoin-project/lotus#1136

The issue code has been submitted. Whether the status of the issue should be modified from open bounds to in progress. Thanks

@jennijuju
Copy link
Member

@vnessasgrt ^

@vnessasgrt vnessasgrt assigned kaola526 and unassigned vnessasgrt Sep 27, 2021
@kaola526
Copy link
Author

Create a local multi sign wallet lotus wallet new
--Update:lotus msig create --import=true
Approve to multi address transaction lotus wallet approve
--Update:lotus msig approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@dayou5168 @coder-lb @jennijuju @vnessasgrt @kaola526 and others