Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove the /hapi/ UI and migrate all functionality into WebRPC + lit mjs #113

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Jul 21, 2024

Feat: Remove the /hapi/ UI and migrate all functionality into WebRPC + lit mjs

@snadrus snadrus requested a review from magik6k July 21, 2024 04:50
@snadrus snadrus marked this pull request as draft July 21, 2024 04:50
@magik6k
Copy link
Collaborator

magik6k commented Jul 22, 2024

The only 'hapi' ref is in index.html:
<tbody hx-get="/hapi/simpleinfo/actorsummary" hx-trigger="load,every 5s">

A rebase will fix this now

@snadrus
Copy link
Contributor Author

snadrus commented Jul 23, 2024

Please test on a full environment (or add to a TailScale machine so I can test).
I completed testing in my local environment but with so many blanks it could have issues rendering things when [].length > 0

@snadrus snadrus marked this pull request as ready for review July 23, 2024 04:08
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks docker devnet logs. Although the Curio node is started in the end correctly. Not sure what's going on here.

2024-07-24 14:18:33 The head is now greater than 9: 10
2024-07-24 14:18:33 All ready. Lets go
2024-07-24 14:18:33 Wait for lotus-miner is ready ...
2024-07-24 14:18:33 Create a new miner actor ...
2024-07-24 14:18:33 2024-07-24T10:18:33.863Z    INFO    lotus-shed      lotus-shed/miner.go:346 Pushed CreateMiner message: bafy2bzacebcl4tfyr2ric3ph7m6nhn4d6ajeog24esewnxmmh3fjti5v3cno6
2024-07-24 14:18:33 2024-07-24T10:18:33.863Z    INFO    lotus-shed      lotus-shed/miner.go:347 Waiting for confirmation
2024-07-24 14:19:01 2024-07-24T10:19:01.006Z    INFO    lotus-shed      lotus-shed/miner.go:363 New miners address is: t01002 (t2snmkjqamg4afxwwwh4amuubfuwiv5eyqhhhoy6y)
2024-07-24 14:19:01 New Miner is t01002
2024-07-24 14:19:01 Initiating a new Curio cluster ...
2024-07-24 14:19:33 The base layer has been updated with miner[s] [t01002]
2024-07-24 14:19:33 Enabling market ...
2024-07-24 14:19:33 Layer seal created/updated
2024-07-24 14:19:33 Starting Curio node to attach storage ...
2024-07-24 14:19:33 repopath /var/lib/curio
2024-07-24 14:19:33 ERROR: querying version: RPC client error: sendRequest failed: Post "http://172.20.0.4:12300/rpc/v0": dial tcp 172.20.0.4:12300: connect: connection refused
2024-07-24 14:19:33 
2024-07-24 14:19:33 Waiting for the curio CLI to become ready...
2024-07-24 14:19:38 remote node version: [1 22 1]
2024-07-24 14:19:38 remote node version: [1 22 1]
2024-07-24 14:19:38 Stopping Curio node ...
2024-07-24 14:19:38 Try to stop boost...
2024-07-24 14:19:38 Done
2024-07-24 14:19:38 Starting curio node ...
2024-07-24 14:19:38 
- Ctrl+C pressed in Terminal
2024-07-24 14:19:38 repopath /var/lib/curio

@LexLuthr
Copy link
Contributor

Found the following issues in UI:

  1. PoRep pipeline is complete empty
Screenshot 2024-07-24 at 2 35 33 PM
  1. 24 hour task count is below recently finished
Screenshot 2024-07-24 at 2 34 41 PM
  1. Home page PoRep pipeline table is messed up
Screenshot 2024-07-24 at 2 34 28 PM
  1. Deal menu item is not aligned
Screenshot 2024-07-24 at 2 35 04 PM

@LexLuthr
Copy link
Contributor

In the "Node" page, we should align all 4 tables in 2x2 grid. It would save space and reduce unnecessary scrolling.

@LexLuthr
Copy link
Contributor

I have fixed all the issues I found. 2 remaining things I punted are:

  1. Sector list filter based on miner ID
  2. Rearrange node details and home page to be less cluttered.

@snadrus snadrus merged commit c816d0f into main Jul 25, 2024
7 checks passed
@snadrus snadrus deleted the feat/no-hapi branch July 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants