-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate the harmony_task_history
table with the sector
#149
Associate the harmony_task_history
table with the sector
#149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this; I'd avoid the msgpack dependency, I don't think the complexity is worth the minimal savings it can get us, and it makes querying details much harder
harmony_task_history
table with the sector.
harmony_task_history
table with the sector.harmony_task_history
table with the sector
I would not recommend this approach at all. Changing the harmonyTask to be sector specific is not a good idea. HarmonyTask is generic for a reason. This would thrown a wrench in our plans to later do market, PDP and other things. A separate Event table would be far better. Harmony history should have nothing to do with sector events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, I'd still improve 2 small things, especially the schema change which will be hard to change after this lands
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should record events regardless of failure or success. If we only record success, chances are we will never actually use them. Why would you check logs for working system? We should record all failures as well.
We also need some kind of cleanup mechanism for this table. It will grow very quickly on large clusters.
@LexLuthr Totally agree. We manage over 100 miners, so the data volume could become very large, but I'm afraid that too many changes will make this PR increasingly complex.😀I will keep records of successes and failures in this PR. |
I would say this is still a relatively smaller PR. We can add cleanup in this and mark this as a feature with documentation on how to get these events from CLI. |
I confirmed again that the history table records failed entries, so the event table will also default to recording failed entries. Regarding data growth, as Magik6k mentioned, SST compression might be helpful. It seems that the history table will impose a greater load compared to the event table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extremely useful, thanks for the PR!
No description provided.