Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmrpc: Avoid table scans in SectorsStatus #165

Merged
merged 2 commits into from
Aug 22, 2024
Merged

lmrpc: Avoid table scans in SectorsStatus #165

merged 2 commits into from
Aug 22, 2024

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Aug 22, 2024

Afaict the query behavior is exactly the same, it just uses 2 more CTE to guide postgres to use the correct indexes

@magik6k magik6k requested a review from LexLuthr August 22, 2024 12:41
@magik6k
Copy link
Collaborator Author

magik6k commented Aug 22, 2024

Now this also contains fixes from #156

LexLuthr
LexLuthr approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I missed the some parts of query in the original PR.

@LexLuthr LexLuthr mentioned this pull request Aug 22, 2024
Closed
@magik6k magik6k merged commit a7c73d5 into main Aug 22, 2024
8 checks passed
@magik6k magik6k deleted the fix/no-scan-sectorstatus branch August 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @LexLuthr