Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update the UI for the config list page #189

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

anhoffa
Copy link
Contributor

@anhoffa anhoffa commented Sep 3, 2024

List of changes:

  • updated the UI for the config list page

new:
curio-new-config-list

old:
curio-old-config-list

  • added a StyledLitElement that allows the custom components to inherit global styles. Styling can be applied in two ways:
class LitComponent extends StyledLitElement {
  static get styles() {
    return [
      StyledLitElement.styles,
      css`...`
    ]
  };
  ...
}

or

class LitComponent extends StyledLitElement {
  ...
}

LitComponent.styles = css`...`
  • changed url from /config/ to /pages/config/list/
  • in the layer list, changed the information about the node addresses to the number of nodes (per @magik6k's request)

@snadrus
Copy link
Contributor

snadrus commented Sep 3, 2024

Concern 1: Knowing which box is using a config and needs a restart is an important piece of this thing.

@magik6k
Copy link
Collaborator

magik6k commented Sep 3, 2024

Concern 1: Knowing which box is using a config and needs a restart is an important piece of this thing.

I don't think this is something we can fit reasonably on this page, it can be added to the layer/editor page later imo. Putting node lists here makes this page unreadable in any non-tiny cluster

@magik6k
Copy link
Collaborator

magik6k commented Sep 3, 2024

What would help a lot more, but definitely isn't scope for this PR would be some kind of config versions page, showing nodes which run outdated configuration, which layers changed, and maybe have options to schedule restarts

(nodes could also pick up that their binaries got updated and also suggest restarting on that page)

@strahe
Copy link
Contributor

strahe commented Sep 3, 2024

What would help a lot more, but definitely isn't scope for this PR would be some kind of config versions page, showing nodes which run outdated configuration, which layers changed, and maybe have options to schedule restarts

(nodes could also pick up that their binaries got updated and also suggest restarting on that page)

This sounds very cool.

@snadrus snadrus self-requested a review September 3, 2024 20:21
web/static/ux/css-reset.js Show resolved Hide resolved
@magik6k magik6k merged commit 2da3d19 into filecoin-project:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants