Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no more lotus build #63

Merged
merged 34 commits into from
Jul 16, 2024
Merged

no more lotus build #63

merged 34 commits into from
Jul 16, 2024

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Jun 19, 2024 •
edited
Loading

Dropping all deps that get to lotus/build
waiting on filecoin-project/lotus#12112

@snadrus snadrus marked this pull request as ready for review July 11, 2024 22:35
@snadrus snadrus requested review from LexLuthr and magik6k July 11, 2024 22:35
magik6k
magik6k approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small nitpicks, other than that looks good, just:

  • Needs main merge-in
  • Needs lotus dep update if not on latest lotus master
  • After merge would be a good idea to re-test guided-setup

documentation/en/curio-cli/sptool.md Show resolved Hide resolved
market/lmrpc/minerhandler.go Show resolved Hide resolved
@snadrus snadrus merged commit 13e72ed into main Jul 16, 2024
8 checks passed
@snadrus snadrus deleted the feat/no-lotus-build branch July 16, 2024 20:29
@LexLuthr LexLuthr mentioned this pull request Jul 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@LexLuthr LexLuthr Awaiting requested review from LexLuthr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snadrus @magik6k