Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the whole chain when keying for proposals #147

Closed
Kubuxu opened this issue Apr 2, 2024 · 1 comment · Fixed by #149
Closed

Use the whole chain when keying for proposals #147

Kubuxu opened this issue Apr 2, 2024 · 1 comment · Fixed by #149
Assignees

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Apr 2, 2024

Currently, we only use the head, which leads to confusion between ABC and ABxC chains.
https://filecoinproject.slack.com/archives/C06NTU2DPN1/p1712054917063199

@anorth
Copy link
Member

anorth commented Apr 2, 2024

Note this applies to both the quorumState used for most phases, and the convergeState.

However, I am not sure how much of a problem this actually is. Finality decisions are ultimately about tipsets, and the data about the rest of the chain is in most cases redundant.

@anorth anorth self-assigned this Apr 2, 2024
@rjan90 rjan90 added this to FilOz Apr 3, 2024
@rjan90 rjan90 moved this to ☑️Done (Archive) in FilOz Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

2 participants