Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align tipset identifier with the FIP #148

Closed
anorth opened this issue Apr 2, 2024 · 1 comment
Closed

Align tipset identifier with the FIP #148

anorth opened this issue Apr 2, 2024 · 1 comment

Comments

@anorth
Copy link
Member

anorth commented Apr 2, 2024

The FIP at present specifies tipset identifiers as []Cid in message. The code instead uses an opaque string (byte array). CIDs are opqaue to the protocol so there's not a good reason to depend on a CID package or import any semantics. But since CID has a specific IPLD tag, there's a mismatch to be bridged somewhere.

@Kubuxu
Copy link
Contributor

Kubuxu commented May 15, 2024

Closing given #166

@Kubuxu Kubuxu closed this as completed May 15, 2024
@github-project-automation github-project-automation bot moved this to Done in F3 May 15, 2024
@rjan90 rjan90 moved this to ☑️Done (Archive) in FilOz May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ☑️ Done (Archive)
Development

No branches or pull requests

2 participants