Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power table commitment (CID) and accessory commitment to Tipset structure #150

Closed
Tracked by #14
anorth opened this issue Apr 2, 2024 · 1 comment · Fixed by #216
Closed
Tracked by #14

Add power table commitment (CID) and accessory commitment to Tipset structure #150

anorth opened this issue Apr 2, 2024 · 1 comment · Fixed by #216
Labels
gossipbft Relates to core GossipPBFT protocol

Comments

@anorth
Copy link
Member

anorth commented Apr 2, 2024

Add a power table commitment and a placeholder for an accessory commitment into the Tipset structure. Both are opaque to GPBFT but must be included in considerations of equality and signing payloads (wait for #149 first).

See FIP PR filecoin-project/FIPs#983

@anorth anorth added the gossipbft Relates to core GossipPBFT protocol label Apr 2, 2024
@rjan90 rjan90 added this to FilOz Apr 3, 2024
@anorth
Copy link
Member Author

anorth commented Apr 11, 2024

The tipset structure used within gpbft was replaced with an opaque byte array. We'll probably need a new structure defined further out in the integration layer, to which these fields are added.

@Kubuxu Kubuxu added this to the F3 Alpha milestone Apr 22, 2024
@jennijuju jennijuju added this to F3 May 15, 2024
@jennijuju jennijuju moved this to Ready in F3 May 15, 2024
@jennijuju jennijuju removed this from FilOz May 16, 2024
@Stebalien Stebalien moved this from Todo to In review in F3 May 17, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in F3 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gossipbft Relates to core GossipPBFT protocol
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants