Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Provider creates informative names for deal data staged via the FileStore #583

Open
frrist opened this issue Jul 21, 2021 · 0 comments · May be fixed by #584
Open

Storage Provider creates informative names for deal data staged via the FileStore #583

frrist opened this issue Jul 21, 2021 · 0 comments · May be fixed by #584
Labels
enhancement New feature or request

Comments

@frrist
Copy link
Member

frrist commented Jul 21, 2021

Background

This issue is motivated by filecoin-project/lotus#5291. Users have requested that the temporary files created by the FileStore have a more informative name when they are staged before being passed off to the Storage Miner Module.

Where to Begin

go-fil-markets/storagemarket/impl/provider.go

Lines 294 to 301 in 46f73ec

tempfi, err := p.fs.CreateTemp()
if err != nil {
return xerrors.Errorf("failed to create temp file for data import: %w", err)
}
cleanup := func() {
_ = tempfi.Close()
_ = p.fs.Delete(tempfi.Path())
}

@frrist frrist added the enhancement New feature or request label Jul 21, 2021
@frrist frrist mentioned this issue Jul 21, 2021
Closed
@frrist frrist changed the title Storage Provider creates imformative names for deal data staged via the FileStore Storage Provider creates informative names for deal data staged via the FileStore Jul 21, 2021
frrist added a commit that referenced this issue Jul 21, 2021
@frrist
feat(FileStore): CreateTemp accepts pattern used for file name
69cd693 
- closes #583
@frrist frrist linked a pull request Jul 21, 2021 that will close this issue
Open
frrist added a commit that referenced this issue Jul 21, 2021
@frrist
feat(FileStore): CreateTemp accepts pattern used for file name
2490eef 
- closes #583
frrist added a commit that referenced this issue Jul 26, 2021
@frrist
feat(FileStore): CreateTemp accepts pattern used for file name
b3408cb 
- closes #583
frrist added a commit that referenced this issue Jul 26, 2021
@frrist
feat(FileStore): CreateTemp accepts pattern used for file name
49a0bdf 
- closes #583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(FileStore): CreateTemp accepts pattern used for file name filecoin-project/go-fil-markets
1 participant
@frrist