You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the various voucher / voucher result types used in go-data-transfer to work with the proposed updates to the voucher system in filecoin-project/go-data-transfer#305
The current voucher / voucher result types that need to be converted to bindnode are as follows:
v0 retrieval types -- we have some additional older versions of the retrieval types which have been forever and have long since stopped being used in any running version of Lotus or filclient. What a great opportunity to delete them!
retrieval DealProposal type -- probably the biggest landmine is that the DealProposal type has a selector, that is current encoded as a cbg.Deferred. This should definitely become an Any in schema and a datamodel.Node in the node. However, an additional issues is that DealProposal is currently encoded in the client and provider on disk states, which are CBOR-gen types. I'm not exactly sure how to solve this. Two ideas I had are --
1. Make a seperate copy for the vouchers
2. Implement the expected cbor-gen methods -- there are only two -- https://github.com/whyrusleeping/cbor-gen/blob/master/utils.go#L130 & https://github.com/whyrusleeping/cbor-gen/blob/master/utils.go#L134 -- using ipld-primes dagcbor methods -- if you do this I think maybe it will serialize / deserialize properly?
The text was updated successfully, but these errors were encountered:
What
Update the various voucher / voucher result types used in go-data-transfer to work with the proposed updates to the voucher system in filecoin-project/go-data-transfer#305
The current voucher / voucher result types that need to be converted to bindnode are as follows:
Most of our code using these vouchers can be found in:
Landmines
1. Make a seperate copy for the vouchers
2. Implement the expected cbor-gen methods -- there are only two -- https://github.com/whyrusleeping/cbor-gen/blob/master/utils.go#L130 & https://github.com/whyrusleeping/cbor-gen/blob/master/utils.go#L134 -- using ipld-primes dagcbor methods -- if you do this I think maybe it will serialize / deserialize properly?
The text was updated successfully, but these errors were encountered: