Use a struct over global vars in default_syncer_test #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, quite a few conflicts - if this is generally the right track let me know and I'll fix them. Would prefer to know the solution is OK before resolving. |
mslipper
changed the title
|
@mslipper this is definitely the right approach and generally great. As you've probably already seen the conflicts are most likely all related to our new usage pattern around the require and assert packages introduced in PR #2657. These should be mostly orthogonal and hopefully make the rebase process simple (though surely tedious). |
|
Excellent. I'll resolve the conflicts shortly. |
mslipper
force-pushed
the
issue-2116
branch
2 times, most recently
from
57ab497 to
2ce5cbb
Compare
ZenGround0
approved these changes
May 7, 2019
frrist
approved these changes
May 22, 2019
shannonwells
approved these changes
May 22, 2019
There was a problem hiding this comment.
once @frrist 's comments are addressed, gtg... thanks for taking on this tedious task. so much better now
deaswang
pushed a commit
to filcloud/go-filecoin
that referenced
this pull request
May 24, 2019
…t#2700) * Use a struct over global vars in default_syncer_test Closes filecoin-project#2116. * Remove bad unit test flags * Add UnitTest flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2116. All
*Testmethods initialize a struct that contains the syncer params, which is in turn passed to all the other initialization/require*methods. Let me know if there's an alternative approach you'd like me to implement.