-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create fast environment package #2919
Conversation
8df4d55
to
c8d373f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
========================================
- Coverage 43% 41% -2%
========================================
Files 210 136 -74
Lines 12466 8278 -4188
========================================
- Hits 5389 3436 -1953
+ Misses 6262 4259 -2003
+ Partials 815 583 -232
|
153760f
to
a998dfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks ok but the intent is totally opaque, so please expand on documentation before landing.
TeardownProcess(context.Context, *Filecoin) error | ||
TeardownProcess(context.Context, *fast.Filecoin) error | ||
|
||
// GetFunds retrieves a fixed amount of tokens from the environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs more explanation. The method only returns an error, so what does "get" mean? From where are they got? Where is the fixed amount specified? Are they guaranteed to have landed when this method returns?
Edit: having now read implementation, it would probably be better to be more explicit and call this RequestFaucetFunds
or similar. The questions above still stand.
6b52262
to
531dc1d
Compare
improve error handling of GetFunds on devnet env
531dc1d
to
3c7eedb
Compare
Wat
This PR repackages the way FAST is laid out to make it more friendly to work with deps
This PR adds
GetFunds
to the environment interface and modifies DevNet and MemoryGenesis to impl it.