Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration of Lassie from startup to a per fetch basis. #259

Open
kylehuntsman opened this issue May 26, 2023 · 2 comments
Open
Labels
tech debt Non-critical change that can wait to be addressed

Comments

@kylehuntsman
Copy link
Contributor

We can currently have configuration for a Lassie instance that is used on startup, but we have slowly added features that allow that same configuration on a per fetch basis. Documentation around this might be confusing or not very straightforward for a user trying to use Lassie. We have started to favor per fetch configuration. We should move the configuration from the initialization of a Lassie instance to the fetch call.

@kylehuntsman kylehuntsman added the tech debt Non-critical change that can wait to be addressed label May 26, 2023
@hannahhoward
Copy link
Collaborator

@kylehuntsman One clarifying thing here: what we want to deal with is situations where the configuration is in both places, and in those situations, remove the "on construction" configuration.

Of the top of my head, some parameters that I'm aware of being doubled are:

  • peer selection
  • protocol selection
  • max blocks
  • possibly others

The ticket starts with an audit to figure out what duplicates exists, and then figuring out how to remove the on startup options.

@hannahhoward
Copy link
Collaborator

also one clarifying piece: when we say "on startup" we really mean on construction of a Lassie instance. For the fetch command, we only make one request, but we should still convert the CLI parameters to request parameters. For the daemon, parameters that can be configured on requests generally shouldn't be available as CLI options -- i.e. for daemon, I don't get to say I want fixed peers, unless I do it as an parameter when making an HTTP request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Non-critical change that can wait to be addressed
Projects
None yet
Development

No branches or pull requests

2 participants