Skip to content

Commit

Permalink
fixup! fix(f3): test API during inactive-F3 modes and make consistent…
Browse files Browse the repository at this point in the history
… and safe
  • Loading branch information
rvagg committed Dec 13, 2024
1 parent 5e855d9 commit 3631bf6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion chain/lf3/f3.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (fff *F3) GetManifest(ctx context.Context) (*manifest.Manifest, error) {
}
cert0, err := fff.inner.GetCert(ctx, 0)
if err != nil {
return m, xerrors.Errorf("getting certificate for instance 0: %w", err)
return m, nil // return manifest without power table
}

var mCopy = *m
Expand Down
4 changes: 3 additions & 1 deletion itests/f3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ func (e *testEnv) waitTillF3Instance(i uint64, timeout time.Duration) {
func (e *testEnv) waitTillManifestChange(newManifest *manifest.Manifest, timeout time.Duration) {
e.waitFor(func(n *kit.TestFullNode) bool {
m, err := n.F3GetManifest(e.testCtx)
require.NoError(e.t, err)
if err != nil || m == nil {
return false
}
return newManifest.Equal(m)
}, timeout)
}
Expand Down

0 comments on commit 3631bf6

Please sign in to comment.