Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitstore: next steps #5789

Closed
1 of 5 tasks
vyzo opened this issue Mar 11, 2021 · 1 comment
Closed
1 of 5 tasks

Splitstore: next steps #5789

vyzo opened this issue Mar 11, 2021 · 1 comment
Assignees
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs

Comments

@vyzo
Copy link
Contributor

vyzo commented Mar 11, 2021

Now that we have shipped the first version of splitstore, we are looking for ways to improve it with the long term goal of making it the default in the future.

Here are some steps that we plan to take to improve it further:

  • Merge splitstore: compact hotstore prior to garbage collection #5778
  • Adjust options for the coldstore badger so that it doesn't memmap and put pressure in the memory subsystem whenever another node is syncing off a splitstore node.
  • Kill compactFull; it was originally written with an eye towards garbage collection, but it hasn't proven very useful so far; all our nodes all use simple compaction (Splitstore optimizations #5808)
  • WalkSnapshot is marking as live more objects that we need, as it effectively walks the chain all the way to genesis; we really don't need to keep old blocks in the hot range. It is also very slow (precisely because it walks all the way to genesis). So the plan is to replace WalkSnapshot with an optimized variant that only marks reachable state roots and not old blocks and stops once we are out of finality range (Splitstore optimizations #5808)
  • Tracking store: use nil valued keys embedding the write tipset in a compound key <write_tipset>:<cid> as this allows us to do very efficient range scans.
@vyzo vyzo assigned vyzo and raulk Mar 11, 2021
@vyzo vyzo added the team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs label Mar 11, 2021
@jennijuju jennijuju added this to the █Blockstore Improvements milestone May 10, 2021
@vyzo
Copy link
Contributor Author

vyzo commented Aug 17, 2021

These have been addressed with splitstore v1.

@vyzo vyzo closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/ignite Issues and PRs being tracked by Team Ignite at Protocol Labs
Projects
None yet
Development

No branches or pull requests

3 participants