Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 1.7.0 cannot cancel-retrieve #5938

Closed
ghost opened this issue Apr 2, 2021 · 7 comments
Closed

[BUG] 1.7.0 cannot cancel-retrieve #5938

ghost opened this issue Apr 2, 2021 · 7 comments

Comments

@ghost
Copy link

ghost commented Apr 2, 2021

Describe the bug

In Lotus 1.5.x, receiving channels had monotonically increasing integer ids like 1, 2, 3, etc. You could cancel a retrieve by using a command like: lotus client cancel-retrieval --deal-id=3.

In 1.7.0, the receiving channel ids seem to be bigints and you cannot cancel them. Here is an example. First, here is my one receiving channel with id = 1617328731745316884:

$ lotus client list-transfers
Sending Channels



Receiving Channels

ID                   Status           Receiving From  Root Cid     Initiated?  Transferred  Voucher
1617328731745316884  ResponderPaused  ...XqC2kG9f     ...2n4oe546  Y           1.052MiB     ...lIncrease":1048576,"UnsealPrice":"0"}

Try to cancel it and get this error:

$ lotus client cancel-retrieval --deal-id=1617328731745316884
ERROR: failed to cancel retrieval deal: loadOrCreate state: saving initial state: failed to write cid field t.PayloadCID: undefined cid

Check again and the receiving channel did indeed fail to get canceled:

$ lotus client list-transfers
Sending Channels



Receiving Channels

ID                   Status           Receiving From  Root Cid     Initiated?  Transferred  Voucher
1617328731745316884  ResponderPaused  ...XqC2kG9f     ...2n4oe546  Y           1.052MiB     ...lIncrease":1048576,"UnsealPrice":"0"}

Version (run lotus version):

I'm using the current tip of master:

$ lotus version
Daemon:  1.5.3+mainnet+git.358773e2b+api1.1.0
Local: lotus version 1.5.3+mainnet+git.358773e2b

To Reproduce

Kick off a retrieval of any CID, e.g., lotus client retrieve --miner f01240 bafykbzacea5dewvdatvbxc2tmi26bomowduqhoi7ery4yqi3n6li32n4oe546 baf-oe546.bin

Then follow the steps under "Describe the Bug" to reproduce.

Expected behavior

lotus client cancel-retrieval --deal-id=1617328731745316884 should have successfully canceled that retrieval.

Logs
Not available.

@jimpick
Copy link
Contributor

jimpick commented Apr 2, 2021

I assume the transfer id is different than the deal id. The deal ids for the retrievals aren't in the CLI anywhere as far as I can tell.

@dirkmc
Copy link
Contributor

dirkmc commented Apr 2, 2021

I suspect that the error is coming from switching between branches, one of which has a migration. Details here:
#5901

@ghost
Copy link
Author

ghost commented Apr 2, 2021

@dirkmc That makes sense. I'll wipe out my .lotus directory and try again to see if it's still happening. (and stop switching branches ;))

@jennijuju
Copy link
Member

@dirkmc That makes sense. I'll wipe out my .lotus directory and try again to see if it's still happening. (and stop switching branches ;))

@mgoelzer was it resolved?

@jennijuju jennijuju added need/author-input Hint: Needs Author Input and removed hint/needs-triaging kind/bug Kind: Bug labels Apr 2, 2021
@ghost
Copy link
Author

ghost commented Apr 2, 2021

@jennijuju I haven't had time to re-test yet and I probably won't until next week. Why don't we close out this issue for now? If I retest and discover the same problem, or if you notice a similar bug report from someone else, we can reopen.

@github-actions
Copy link

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 24 hours.

@github-actions
Copy link

This issue was closed because it is missing author input.

@TippyFlitsUK TippyFlitsUK removed the need/author-input Hint: Needs Author Input label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants