-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fstmp files not removed when import failed #8775
Comments
Hi @RobQuistNL I believe that these files are garbage collected at miner restart. Can you please restart your instance and report back? Many thanks! |
no 😅 I don't want garbage collection (I can do that myself too) - I want Lotus to properly clean up after itself 😋 |
https://github.com/filecoin-project/go-fil-markets/blob/master/filestore/filestore.go I think its coming from here |
Or actually, this one just isn't called properly; |
It seems cleanup function is called up manually after each error state. I haven't checked the complete path till addpiece() is called but a better way would be to defer cleanup() in the https://github.com/filecoin-project/go-fil-markets/blob/v1.20.1/storagemarket/impl/provider.go#L339 and use the original file path for the addpiece after verifying that car file is good to import. Not sure why we are importing from the temporary file path here. |
@dirkmc This is the issue we were discussing in the meeting. Can you take a look at this? |
@RobQuistNL Can you get me the deal state after import failure? I need to understand sectors state and piece's state. So, I can trace what is being traced in the market FSM to try to figure out why delete is not happening. |
Hi 👋 The Legacy Lotus Markets sub-system reached EOL at the end of the 31st January 2023. This ticket is being marked as Please feel free to re-open this ticket in the new Boost markets sub-system repository at https://github.com/filecoin-project/boost if you feel that it is still relevant. Many thanks 🙏 |
Checklist
Latest release
, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Describe the Bug
When we import a deal, and the importing fails with;
after running or 3 minutes - the fstmp file is not removed.
Logging Information
Repo Steps
No response
The text was updated successfully, but these errors were encountered: