Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: beacon: validate drand change at nv16 correctly #11690

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Mar 6, 2024

Related Issues

@rvagg reported an inability to sync epoch 510 on calibnet, the UpgradeSkyrHeight (nv16). This is because that upgrade included a "bump" in drand, that required 2 rounds to be included at that epoch. For more see #2170 and #8606.

The implementation of FIP-0073 introduced a new check that block headers only include precisely those rounds as matching the block epochs. This check works correctly for all epochs EXCEPT the UpgradeSkyrHeight, but is only needed for nv22 and after when we have unchained randomness.

Proposed Changes

Apply the new check only if the source of randomness is unchained (effectively saying nv22 and after only).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner March 6, 2024 17:28
@arajasek arajasek merged commit 1f6e556 into release/v1.26.0 Mar 6, 2024
90 checks passed
@arajasek arajasek deleted the asr/fix-drand-skyr branch March 6, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants